ml-kem: rename EncodedSizeUser::as_bytes => to_bytes
#180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...as impl'd on `EncapsulationKey` and `DecapsulationKey`. According to: https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv - `as_` is for free borrowed -> borrowed conversions - `to_` is for expensive borrowed -> owned conversions (used here) Also, `to_bytes` better pairs with `from_bytes`.
tarcieri
force-pushed
the
ml-kem/rename-as-bytes-to-bytes
branch
from
f06520b to
8458fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...as impl'd on
EncapsulationKeyandDecapsulationKey. According to:https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv
as_is for free borrowed -> borrowed conversionsto_is for expensive borrowed -> owned conversions (used here)Also,
to_bytesbetter pairs withfrom_bytes.