Update & refactor json-b64 crate #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Json`, `Bytes`, and `Secret` are now exported at top level - Rename `Bytes` to `B64Bytes` and `Secret` to `B64Secret` to better reflect their purpose - Add example to readme - Rename internal modules for clarity
Member
|
@tgross35 can you rebase? That should fix the test failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json,Bytes, andSecretare now exported at top levelBytestoB64BytesandSecrettoB64Secretto better reflect their purpose (this is optional, can revert if desired)This somewhat improves the usability of the b64 crate. It is a breaking change, but I don't think many people are using this crate as-is.