Eng 3068 create node result qet routes for metrics and checks#1403
Open
eunice-chan wants to merge 7 commits intomainfrom
Open
Eng 3068 create node result qet routes for metrics and checks#1403eunice-chan wants to merge 7 commits intomainfrom
eunice-chan wants to merge 7 commits intomainfrom
Conversation
…reate-nodemetricresultsgetquery-nodecheckresultsgetquery
likawind
reviewed
Jun 5, 2023
likawind
reviewed
Jun 5, 2023
| } | ||
|
|
||
| responses := make([]response.OperatorWithArtifactResultNode, 0, len(results)) | ||
| for dbDagId, nodeResults := range nodeResultByDagId { |
Contributor
There was a problem hiding this comment.
Try to consolidate these repeating parts. We can file a task if the solution is not immediately clear
likawind
reviewed
Jun 5, 2023
likawind
approved these changes
Jun 5, 2023
Contributor
likawind
left a comment
likawind
left a comment
There was a problem hiding this comment.
Great work, a couple nits but I think the routes are good to go!
likawind
approved these changes
Jun 5, 2023
Contributor
likawind
left a comment
likawind
left a comment
There was a problem hiding this comment.
Great work, a couple nits but I think the routes are good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Add result history routes for checks and metrics for use in the history display status bug (ENG-2578).
Tested in test_reads.py
Related issue number (if any)
ENG 3068
ENG-2578
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)