Skip to content

[Feat/get crew home] 크루홈 조회 api 구현 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeeheaG merged 25 commits into from
Mar 7, 2025
Merged

[Feat/get crew home] 크루홈 조회 api 구현 #87

jeeheaG merged 25 commits into from
Mar 7, 2025

Conversation

@jeeheaG
Copy link
Contributor

@jeeheaG jeeheaG commented Mar 6, 2025 •
edited
Loading

작업한 내용을 설명해주세요 ✔️

  • get crew home : 크루 조회 api
    크루에 가입된 사람만 조회할 수 있는 크루홈 조회입니다.
    • 크루의 월간 기록
      • 아직 값 반영 로직없이 필드만 존재합니다. (total_running_count, total_distance, total_time)
      • 완료된 러닝이 추가될때마다 기록을 갱신하는 걸로 구상했는데, 갱신 로직이 아직 존재하지 않습니다.
      • 스케쥴러 써서 월 바뀔때마다 모든 월간 기록을 초기화시키는 걸로 구상했는데, 해당 로직이 아직 존재하지 않습니다.
    • 런 카드 상단 보라색글씨 : 전략 패턴으로 구현

리뉴얼 후에도 이 기능이 남아있다면 추후 구현하도록 하겠습니다.

** 크루홈 조회에서 유저 정보를 조회하는 부분이 있는데,
이 때 테스트용 회원가입&로그인을 사용한 계정일 경우 User 의 Profile 이 존재하지 않아서 에러가 난다는 점 참고해주세요. DB 에서 해당 계정 profile 넣어줘야 정상 작동합니다.

감사합니다.

확인하기

  • : 코드에 에러가 없는지 확인했나요?
  • : PR에 설명을 기재했나요?
  • : PR 태그를 붙였나요?
  • : 불필요한 로그나 System.out을 제거했나요?

jeeheaG added 22 commits January 1, 2025 16:50
@jeeheaG
✨ edit : edit get crew home and info page status code
0a86005
@jeeheaG
♻️ refactor : rename CommandCrewService
fd92bbe
@jeeheaG
✨ feat : make dtos for UpdateCrewInfo api
65d0106
@jeeheaG
✨ feat : make exception and error code for UpdateCrewInfo api
0138dc5
@jeeheaG
✨ feat : make use case and service logic for UpdateCrewInfo api
34fe056
@jeeheaG
✨ feat : make UpdateCrewInfo api
cda039d
@jeeheaG
♻️ refactor : move crew owner checking logic to CommandCrewService
5204e5f
@jeeheaG
Merge branch 'main' of https://github.com/Run-Us/Run-Us-server into J…
5960a64 
…IS-101-crew-update
@jeeheaG
🐛 solve merge conflict
0f705e6
@jeeheaG
✨ make update crew join rule api
6cf221f
@jeeheaG
✨ make close crew api
707bbce
@jeeheaG
✨ add : make monthlyRecord field
7894813
@jeeheaG
✨ add : make type field in RunningPreview
8e862b2
@jeeheaG
✨ add : make RunTopMessage logic by strategy pattern
c2d5a50
@jeeheaG
✨ add : make findFirstForCrewCard query method
b8a83ac
@jeeheaG
✨ add : make existsByCrewIdAndStatus query method
3719ea5
@jeeheaG
✨ add : make getUserByInternalId method
a67cde6
@jeeheaG
✨ add : move validate logic to CrewValidator
4fab857
@jeeheaG
✨ add : make getCrewCardRun service logic
a84760a
@jeeheaG
✨ add : make existNewJoinRequest service logic
a0bb901
@jeeheaG
✨ feat : make getCrewHome api
b2fc5e4
@jeeheaG
✨ edit : change to use @currentuser
3472c5f
@jeeheaG jeeheaG self-assigned this Mar 6, 2025
@jeeheaG jeeheaG added the ⚒️ enhancement ⚒️ New feature or request label Mar 6, 2025
ekgns33
ekgns33 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@ekgns33 ekgns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴돠!

@jeeheaG jeeheaG merged commit 52e02dd into main Mar 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekgns33 ekgns33 ekgns33 approved these changes

Assignees

@jeeheaG jeeheaG

Labels

⚒️ enhancement ⚒️ New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeeheaG @ekgns33