Skip to content

[Feat/crew member remove] - 크루 멤버 조회 및 추방 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hughesgoon merged 8 commits into from
Jan 20, 2025
Merged

[Feat/crew member remove] - 크루 멤버 조회 및 추방 #79

hughesgoon merged 8 commits into from
Jan 20, 2025

Conversation

@hughesgoon
Copy link
Collaborator

@hughesgoon hughesgoon commented Jan 15, 2025 •
edited
Loading

연관된 이슈를 적어주세요 📌

JIS-105

작업한 내용을 설명해주세요 ✔️

  • authentication 고쳤습니다. @CurrentUser String currentUserPublicId 동작합니다.
    • idResolver 만들어서 UseCase단에서 public <-> internal 전환하도록 통일했습니다.
    • UseCase return값 SuccessResponse로 통일했습니다.
  • 멤버 조회 기능 만들었습니다.
  • 멤버 추방 기능 만들었습니다.

트러블 슈팅

리뷰어에게 하고 싶은 말을 적어주세요

  • 멤버 조회가 의외로 3개 도메인(크루, 레코드, 유저)이 겹치는 영역이라 쿼리에 대혼란이 펼쳐졌습니다.

확인하기

돌아감! (진짜)

  • : 코드에 에러가 없는지 확인했나요?
  • : PR에 설명을 기재했나요?
  • : PR 태그를 붙였나요?
  • : 불필요한 로그나 System.out을 제거했나요?

@hughesgoon hughesgoon added 🚀 feature 🚀 😄 L1 그렇게 급하지 않음 labels Jan 15, 2025
@hughesgoon hughesgoon requested review from ekgns33 and jeeheaG January 15, 2025 07:55
@hughesgoon hughesgoon self-assigned this Jan 15, 2025
ekgns33
ekgns33 requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@ekgns33 ekgns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! Cache 쪽은 정말 어렵네요. 몇가지 리뷰 달아놓았습니다 :)

@hughesgoon
Copy link
Collaborator Author

hughesgoon commented Jan 19, 2025

PR 리뷰 반영

  • GlobalConst 화이트리스트 타입을 Set으로 변경하고
  • RunRecord가 아니라 Profile에서 totalDistance가져오고
  • PageRequest 페이지네이션 JPA에 적용되게 했습니다.

추가로 캐시는 충돌 안나게 제네릭이 아니라 명시적으로 수정해놨습니다.
Close #76
@ekgns33 @jeeheaG

@hughesgoon hughesgoon requested a review from ekgns33 January 19, 2025 08:07
ekgns33
ekgns33 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@ekgns33 ekgns33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@hughesgoon hughesgoon merged commit b7a25c8 into main Jan 20, 2025
@hughesgoon hughesgoon deleted the feat/crew-member-remove/JIS105 branch January 20, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekgns33 ekgns33 ekgns33 approved these changes

@jeeheaG jeeheaG Awaiting requested review from jeeheaG

Assignees

@hughesgoon hughesgoon

Labels

🚀 feature 🚀 😄 L1 그렇게 급하지 않음

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hughesgoon @ekgns33