Skip to content

Fix/scrolling imp #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OzgeYurtsever wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix/scrolling imp #953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659c5cb
Fix repetitive event listener operation
OzgeYurtsever Dec 16, 2025
db6c3e1
Detach event listener when closing single ports
OzgeYurtsever Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/components/display/displayView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,22 +441,13 @@ class DisplayView extends Component {
window.dispatchEvent(new CustomEvent("unfuse", { detail: { source: 'open' } }));
}

// 1. Check if loading just finished
if (prevState.isLoading && !this.state.isLoading) {
// All DOM for viewports now exists
this.attachListenersToAllViewports();
}

// 1. When loading finishes → viewports first appear
if (prevState.isLoading && !this.state.isLoading) {
this.attachListenersToAllViewports();
return;
}

// 2. When viewport count changes OR viewport content changes
const dataChanged =
this.state.data !== prevState.data ||
this.state.data.length !== prevState.data.length;
const dataChanged = seriesReplaced || series.length !== prevSeries.length;

if (!this.state.isLoading && dataChanged) {
this.attachListenersToAllViewports();
Expand Down Expand Up @@ -500,6 +491,7 @@ class DisplayView extends Component {
el.removeEventListener("mouseup", this.mouseupStopScroll);
el.removeEventListener("mouseleave", this.mouseupStopScroll);
el.removeEventListener("contextmenu", this.preventContextMenu);
console.log("✓ listeners detached from viewport", i);
};

preventContextMenu = (e) => {
Expand Down Expand Up @@ -2852,6 +2844,7 @@ class DisplayView extends Component {
this.setActive(i);
return;
}
this.detachScrollListenersFor(i);
this.closeViewport(i);
};

Expand Down