Skip to content

H3DlgHintBar memory OOB #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RoseKavalier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

H3DlgHintBar memory OOB #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions include/h3api/H3DialogControls/H3DlgHintBar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,16 @@ namespace h3
}
_H3API_ H3DlgHintBar* H3DlgHintBar::Create(H3BaseDlg* dlg)
{
H3DlgHintBar* hint = (H3DlgHintBar*)H3DlgTextPcx::Create(8, dlg->GetHeight() - 26,
dlg->GetWidth() - 16, 19, h3_NullString, NH3Dlg::Text::SMALL,
NH3Dlg::HDassets::HD_STATUSBAR_PCX, eTextColor::REGULAR);
if (hint)
hint->lastHint = nullptr;
return hint;
return H3DlgHintBar::Create(dlg, 8, dlg->GetHeight() - 26, dlg->GetWidth() - 16, 19);
}
_H3API_ H3DlgHintBar* H3DlgHintBar::Create(H3BaseDlg* dlg, INT32 x, INT32 y, INT32 w, INT32 h)
{
H3DlgHintBar* hint = (H3DlgHintBar*)H3DlgTextPcx::Create(x, y, w, h, h3_NullString,
NH3Dlg::Text::SMALL, NH3Dlg::HDassets::HD_STATUSBAR_PCX, eTextColor::REGULAR);
if (hint)
hint->lastHint = nullptr;
H3DlgHintBar* hint = H3ObjectAllocator<H3DlgHintBar>().allocate(1);
if (hint == nullptr)
return nullptr;
THISCALL_12(H3DlgHintBar*, 0x5BCB70, hint, x, y, w, h, h3_NullString, NH3Dlg::Text::SMALL,
NH3Dlg::HDassets::HD_STATUSBAR_PCX, eTextColor::REGULAR, 0, eTextAlignment::MIDDLE_CENTER, 8);
hint->lastHint = nullptr;
return hint;
}
} /* namespace h3 */