areaEl static return for discussion#4
Draft
btopro wants to merge 1 commit intoRolandDreger:masterfrom
Draft
Conversation
Owner
|
I will have a look at it in the next few days when there is more time and also take a closer look at your components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is primarily for feedback / discussion. Our team has found an interesting design paradigm where our render function @heyMP and @nikkimk would have better specific examples but this pr takes an element that's critical to
foot-noteworking visually yet abstracts it to it's own function to supply the dom node.While looking the same in what's created for
foot-noteconsider the following example...While not a perfect example, this would open the door for developers to extend this element, leverage it's accessibility capabilities, while supplying it's own container. For example if our apps have their OWN "foot note visual area" or maybe a consistent pop up / pop over, it would open the door toward leveraging all the internals of your element while supplying our own manner of visualization. This is a need our team has discussed (haxtheweb/issues#280) and has also envisioned potentially as footnote number, click and have it presented in context using a tool tip style presentation.
A PR / template function broken out like this could allow something like that. Opening as Draft as it's mostly conversational / feedback but if you decide to enhance via something like this approach, cool :)