Skip to content

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Jan 3, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

  • Limits max number of keys when updating a department to 50
  • Removes ability to update a department by passing _id inside the department key on livechat/departments endpoint (this was never intended)
  • Updates unit creation logic to avoid re-assigning a unit to a different department without removing it from the prev department first (this was, again, never intended)
  • Updates unit creation logic to reduce number of db calls

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2024

⚠️ No Changeset found

Latest commit: 6514784

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.36%. Comparing base (18a9d65) to head (6514784).
Report is 1984 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31364      +/-   ##
===========================================
+ Coverage    49.34%   49.36%   +0.02%     
===========================================
  Files         3310     3310              
  Lines        81334    81345      +11     
  Branches     16657    16660       +3     
===========================================
+ Hits         40137    40159      +22     
+ Misses       36497    36482      -15     
- Partials      4700     4704       +4     
Flag Coverage Δ
e2e 52.49% <ø> (-0.04%) ⬇️
e2e-api 40.71% <62.50%> (+0.05%) ⬆️
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 15, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 22, 2024
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 22, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 21, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants