fix: overflow on 32-bit builds #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucascool12
force-pushed
the
fix-32bit-build-treemap-len
branch
from
441ee18 to
ebf36a0
Compare
Kerollmops
approved these changes
Jan 12, 2026
Member
Kerollmops
left a comment
Kerollmops
left a comment
There was a problem hiding this comment.
Whoops, yeah, you are absolutely right. Thank you!
Dr-Emann
reviewed
Jan 12, 2026
| /// ``` | ||
| pub fn is_full(&self) -> bool { | ||
| self.map.len() == (u32::MAX as usize + 1) && self.map.values().all(RoaringBitmap::is_full) | ||
| self.map.len() == (u32::MAX as u64 + 1) as usize |
Member
There was a problem hiding this comment.
Isn't this testing that length is zero on a 32 bit machine?
Contributor
Author
There was a problem hiding this comment.
Yes, I really didn't think of this.
Using the len method on a 32-bit machine to test if a RoaringTreemap is full will never work due to the signature of len.
Atleast calling is_full doesn't panic in debug builds now, but this is not a proper fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an overflow bug on 32 bit builds in the
is_fullmethod ofRoaringTreemap.