Merged
Conversation
…cludes a Gregar and Falzar seed. Fixed an issue with adding characters to a byte array that were out of bounds when generating text bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
base_rom_bytesattribute would be used, which could theoretically be the wrong version of the game, leading to generation failures.How was this tested?
Generated multiworld with 45 YAMLs, including multiple Gregar and Falzar worlds. Played a small bit of a seed to verify no obvious issues with playing.
If this makes graphical changes, please attach screenshots.