Adds devcontainer, and poetry for dependency management only#253
Open
hollanbm wants to merge 3 commits intoRickDB:masterfrom
Open
Adds devcontainer, and poetry for dependency management only#253hollanbm wants to merge 3 commits intoRickDB:masterfrom
hollanbm wants to merge 3 commits intoRickDB:masterfrom
Conversation
0a034f0 to
f829630
Compare
Contributor
Author
|
@reconman I suspect there will be a little back and forth on this. But I saw an opportunity to improve the app dev experience and dependency management with poetry I'm not exactly sure what the Tautulli Dockerfile is doing, if you could give some backstory on that, I'll do my best to refactor it as well to leverage poetry. I'm also not sure what the additional repo config in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds devcontainer for consistent/repeatable dev environment
Adds poetry for dependency management only
flake8,pylint, dev dependencies (and vscode extensions)pytesttest dependency (and vscode extension)PlexAniSyncDockerfile for readabilityrootappuser is createdappuser creates/activates venv with poetryI built and tested the refactored container image