Skip to content

Conversation

@jaredlander
Copy link

… on using vector mode. The standard int has a size limit of 2^31 which can be exceeded when computing distance on a matrix with more than 46,342 rows.

I didn't change the matrix return formats because that shouldn't be as much of a problem since you can have a 32-bit integer in either direction.

… on using vector mode. The standard int has a size limit of 2^31 which can be exceeded when computing distance on a matrix with more than 46,342 rows.

I didn't change the matrix return formats because that shouldn't be as much of a problem since you can have a 32-bit integer in either direction.
@jaredlander
Copy link
Author

Just saw your reply. Sorry for the delay. It's not about the loop exceeding the int size, it's about the total size. Particularly proper_size() in src/dists_vec.cpp. Then I changed it everywhere else just to be sure.

@ManosPapadakis95
Copy link
Contributor

You mean for example 50000*50000 which is bigger than 2^31. Yes ok but I will change with size_t and let C++ do its magic. When I change it you better merge the new version to your master or change it by yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants