enable cell number print when verbose logging activates#26
Open
eaidova wants to merge 1 commit intoReviewNB:masterfrom
Open
enable cell number print when verbose logging activates#26eaidova wants to merge 1 commit intoReviewNB:masterfrom
eaidova wants to merge 1 commit intoReviewNB:masterfrom
Conversation
Member
|
@eaidova Thank you for contributing to treon.
I agree that this is useful. In addition to cell index, it would be better to log the cell content as well. E.g. if a user sees that cell #67 failed, there's no easy way (that I know of) in JupyterLab UI to go to cell #67. The user will have to manually start counting from the top. If they also see the cell content then they can |
Author
|
@amit1rrr I think your sggestion maybe too noisy... in case, if error happens there is stack trace with exact stacktrace including cell content. The problematic part for debugging is kernel died (that raised outside notebook and does not have any logging in some cases), so it will required to print every cell... |
Member
Can you please share an example notebook where this happens? |
Author
I was not able reproduce issue locally, only on ci machine, my treon logs looks like: |
Member
|
Thanks for sharing these. Just FYI - I'm out of office for a week. I will review this as soon as I'm back. |
Member
|
Apologies for the delay. The verbose logging should also list the file name since many of them are getting executed in parallel. So there would be no way to catch the culprit based on the current debug logging (see screenshot below). It should be something like -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add info about which cell executed in verbose logs, in some cases this info helpful for search source of Kernel Died error which does not have a lot of logs...