[WIP] Monobehaviour refactoring#674
Draft
StephenHodgson wants to merge 17 commits intoRevenueCat:mainfrom
Draft
Conversation
- Refactored the unity purchases sdk to decouple from MonoBehavior
fixed some typos fixes some missing callbacks
fix more missing callbacks
cleanup usages and return types
fixed some json serialization/deserialization added json exception handling on interop
minor refactoring
updated PurchaesWrapperiOS
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a major breaking change refactor, that decouples the Monobehaviour requirements for the Purchases SDK.
RevenueCatnamespace was added to all types.Purchasespartial class into their own classes under theRevenueCatnamespaceNewtonsoft.Jsonserialization (using the built-in unity package)RevenueCatConfigscriptable object for developers to be able to configure the SDK settings in the new RevenueCat player projects settings window (or directly on the config.asset itself).PurchashesSDKstatic class that is the central point of contact for developers to interact with the SDKTODO