Message ID filtering (SMSCGW to deal with messages that have certain message IDs)

[ovoo-unif]

Hi,

can you please review and consider this PR?

It is needed when trying to run 2 SMSCGW instances connected to cluster of 2 Cassandra nodes.

When SMSC checks for messages that should be re-sent, the instances should deal only with its 'own' messages (each SMSCGW has its own not-overlapping MsgID range).

Possibly it could be resolved in a better way. Anybody has any other ideas on how to achieve it?

Possibly this feature can be made configurable (to be turned on/off by configuration).

With kind regards,
adam

[gsaslis]

Hi @ovoo-unif !

Thanks for the PR ❤️ - appreciate you taking the time to contribute this!!

Could you please go through our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with reviewing this?

Thanks in advance!
Yorgos

[ovoo-unif]

Hi Yorgos,

the CLA is signed.

Regards,
adam

[gsaslis]

Thanks @ovoo-unif !

pushing this for review from the @RestComm/messaging-squad

[vetss]

Hello @ovoo-unif

can you please explain me what is an advantage of usage of a single keyset for 2 SMSC GW instances in case you differentiate messages per a smsc gw instance (you want to smsc gw 2 will not use messages from ussd gw 1 and vice versa).

Differentiating of messageId is not an only problem. SMSC GW is designed now in a way when it thinks that it update a dtabase alone and nobody may update tables. If another server wants to change something in a database then it may confuse of a first server and lead collisions. If we want several SMSC GWs will reuse of a single keyspace we need to make a deep redesign of database usage and such usage means that messages may be loaded and delivered by a second server. IMO only this usage makes sense if we want to use same keyspace for a single keyspace.