Conversation
1. separate prosody and style encoders 2. implement diffusion (Bert embeddings still need work) 3. do proper cross entropy as opposed to the STTS1 way of doing cross entropy, use `s2s_attn_feat` (now just `s2s_attn` like in stts2) directly 4. add `max_len` parameter, may not be needed, but added in case we encounter a massive audio file (simply setting to a very large number will have the same effect) 5. Alter dataloader to support ref_mels and waves (waves is unnecessary, as its used for SLM and decoder losses, but STTS1 isn't end to end, kept in just in case) TODO: Add accelerate to second stage TODO: Un-hardcode all data params (sr, hop, n_fft, etc) TODO: Bert embeddings need to somehow be replaced by something else
swap to t_en
STTS2 backport
Data and embedding changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to look at the changes and close