This repository was archived by the owner on Feb 2, 2019. It is now read-only.
signup UI #7
Open
signup UI #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@devilcrucifier @mr-woot can you review this? and also check for lint, travis will not build if there is something wrong |
Contributor
|
@mr-woot is console.log() best practice ? you told me it's not. I think @Sandeepvarri you have to remove those too. Lemme know if I'm wrong. |
Contributor
Author
|
@prakritidev I will remove while intigrating with google, github and linkedin. |
Contributor
Ok, then do not merge into develop now. When you implement the full implementation, then request for PR on develop . Till then work on your feature branch only. |
Contributor
Author
|
Okay |
Contributor
|
@devilcrucifier checkout the changes, review and merge this branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only implemented UI of signup component