Skip to content

Bring everything up to date and replace HTTParty with Async #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RemoteCTO merged 2 commits into from
Jan 7, 2025
Merged

Bring everything up to date and replace HTTParty with Async #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d185cfe
Bring everything up to date and use async
RemoteCTO Jan 7, 2025
e71bfa7
Update gh workflow
RemoteCTO Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.0.1
ruby-version: 3.4.1
- name: Run the default task
run: |
gem install bundler -v 2.2.15
gem install bundler -v 2.6.2
bundle install
bundle exec rake
55 changes: 25 additions & 30 deletions .rspec_status
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,25 @@
example_id | status | run_time |
--------------------------------------- | ------ | --------------- |
./spec/remoteok/client_spec.rb[1:1] | passed | 0.00902 seconds |
./spec/remoteok/client_spec.rb[1:2:1] | passed | 0.00061 seconds |
./spec/remoteok/client_spec.rb[1:2:2:1] | passed | 0.00042 seconds |
./spec/remoteok/client_spec.rb[1:3:1] | passed | 0.00042 seconds |
./spec/remoteok/client_spec.rb[1:4:1] | passed | 0.00128 seconds |
./spec/remoteok/client_spec.rb[1:4:2] | passed | 0.00042 seconds |
./spec/remoteok/client_spec.rb[1:5:1] | passed | 0.00096 seconds |
./spec/remoteok/client_spec.rb[1:5:2] | passed | 0.00124 seconds |
./spec/remoteok/client_spec.rb[1:5:3:1] | passed | 0.00045 seconds |
./spec/remoteok/client_spec.rb[1:5:4:1] | passed | 0.00058 seconds |
./spec/remoteok/job_spec.rb[1:1] | passed | 0.00041 seconds |
./spec/remoteok/job_spec.rb[1:2:1] | passed | 0.00019 seconds |
./spec/remoteok/job_spec.rb[1:3:1] | passed | 0.00019 seconds |
./spec/remoteok/job_spec.rb[1:4:1] | passed | 0.00019 seconds |
./spec/remoteok/job_spec.rb[1:5:1] | passed | 0.00019 seconds |
./spec/remoteok/job_spec.rb[1:6:1] | passed | 0.00066 seconds |
./spec/remoteok/job_spec.rb[1:7:1] | passed | 0.0002 seconds |
./spec/remoteok/job_spec.rb[1:8:1] | passed | 0.00031 seconds |
./spec/remoteok/job_spec.rb[1:9:1] | passed | 0.00027 seconds |
./spec/remoteok/job_spec.rb[1:10:1] | passed | 0.00023 seconds |
./spec/remoteok/job_spec.rb[1:11:1] | passed | 0.00028 seconds |
./spec/remoteok/job_spec.rb[1:12:1] | passed | 0.00024 seconds |
./spec/remoteok/job_spec.rb[1:13:1] | passed | 0.00035 seconds |
./spec/remoteok/job_spec.rb[1:14:1] | passed | 0.0003 seconds |
./spec/remoteok/job_spec.rb[1:15:1] | passed | 0.00032 seconds |
./spec/remoteok/job_spec.rb[1:16:1] | passed | 0.01251 seconds |
./spec/remoteok/job_spec.rb[1:17:1] | passed | 0.00037 seconds |
./spec/remoteok_spec.rb[1:1] | passed | 0.00017 seconds |
example_id | status | run_time |
-------------------------------------- | ------ | --------------- |
./spec/remote_ok/client_spec.rb[1:1] | passed | 0.00199 seconds |
./spec/remote_ok/client_spec.rb[1:2:1] | passed | 0.00056 seconds |
./spec/remote_ok/client_spec.rb[1:3:1] | passed | 0.00038 seconds |
./spec/remote_ok/client_spec.rb[1:3:2] | passed | 0.00075 seconds |
./spec/remote_ok/client_spec.rb[1:4:1] | passed | 0.00034 seconds |
./spec/remote_ok/job_spec.rb[1:1] | passed | 0.00007 seconds |
./spec/remote_ok/job_spec.rb[1:2:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:3:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:4:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:5:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:6:1] | passed | 0.00021 seconds |
./spec/remote_ok/job_spec.rb[1:7:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:8:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:9:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:10:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:11:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:12:1] | passed | 0.00022 seconds |
./spec/remote_ok/job_spec.rb[1:13:1] | passed | 0.00012 seconds |
./spec/remote_ok/job_spec.rb[1:14:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:15:1] | passed | 0.00019 seconds |
./spec/remote_ok/job_spec.rb[1:16:1] | passed | 0.00006 seconds |
./spec/remote_ok/job_spec.rb[1:17:1] | passed | 0.00006 seconds |
./spec/remote_ok_spec.rb[1:1] | passed | 0.00002 seconds |
26 changes: 8 additions & 18 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,10 @@
AllCops:
NewCops: enable
TargetRubyVersion: 2.6

Style/StringLiterals:
Enabled: true
EnforcedStyle: single_quotes
require:
- standard
- rubocop-rspec
- rubocop-performance

Style/StringLiteralsInInterpolation:
Enabled: true
EnforcedStyle: double_quotes
inherit_gem:
standard: config/base.yml

Layout/LineLength:
Max: 120

Metrics/BlockLength:
Exclude:
- 'Rakefile'
- '**/*.rake'
- 'spec/**/*.rb'
AllCops:
NewCops: enable
5 changes: 5 additions & 0 deletions .standard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
fix: false # default: false
parallel: false # default: false
format: progress # default: Standard::Formatter
default_ignores: true # default: true
#ruby_version: 3.4.1 # default: RUBY_VERSION
20 changes: 12 additions & 8 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
# frozen_string_literal: true

source 'https://rubygems.org'
source "https://rubygems.org"

# Specify your gem's dependencies in remoteok.gemspec
gemspec

gem 'rake', '~> 13.0'

gem 'rspec', '~> 3.0'

gem 'rubocop', '~> 1.7'
gem 'rubocop-rake'
gem 'rubocop-rspec'
# Dev dependencies
group :development, :test do
gem "rake", "~> 13.2"
gem "rspec", "~> 3.13"
gem "rubocop", "~> 1.69"
gem "rubocop-rake"
gem "rubocop-rspec"
gem "rubocop-performance"
gem "simplecov", "< 0.21"
gem "standard", "~> 1.31"
end
147 changes: 100 additions & 47 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,77 +2,130 @@ PATH
remote: .
specs:
remoteok (0.1.0)
httparty (~> 0.18.1)
async-http (~> 0.65)

GEM
remote: https://rubygems.org/
specs:
ast (2.4.2)
diff-lcs (1.4.4)
docile (1.3.5)
httparty (0.18.1)
mime-types (~> 3.0)
multi_xml (>= 0.5.2)
json (2.5.1)
mime-types (3.3.1)
mime-types-data (~> 3.2015)
mime-types-data (3.2021.0225)
multi_xml (0.6.0)
parallel (1.20.1)
parser (3.0.1.1)
async (2.21.1)
console (~> 1.29)
fiber-annotation
io-event (~> 1.6, >= 1.6.5)
async-http (0.86.0)
async (>= 2.10.2)
async-pool (~> 0.9)
io-endpoint (~> 0.14)
io-stream (~> 0.6)
metrics (~> 0.12)
protocol-http (~> 0.43)
protocol-http1 (>= 0.28.1)
protocol-http2 (~> 0.22)
traces (~> 0.10)
async-pool (0.10.2)
async (>= 1.25)
traces
console (1.29.2)
fiber-annotation
fiber-local (~> 1.1)
json
diff-lcs (1.5.1)
docile (1.4.1)
fiber-annotation (0.2.0)
fiber-local (1.1.0)
fiber-storage
fiber-storage (1.0.0)
io-endpoint (0.14.0)
io-event (1.7.5)
io-stream (0.6.1)
json (2.9.1)
language_server-protocol (3.17.0.3)
lint_roller (1.1.0)
metrics (0.12.1)
parallel (1.26.3)
parser (3.3.6.0)
ast (~> 2.4.1)
rainbow (3.0.0)
rake (13.0.3)
regexp_parser (2.1.1)
rexml (3.2.5)
rspec (3.10.0)
rspec-core (~> 3.10.0)
rspec-expectations (~> 3.10.0)
rspec-mocks (~> 3.10.0)
rspec-core (3.10.1)
rspec-support (~> 3.10.0)
rspec-expectations (3.10.1)
racc
protocol-hpack (1.5.1)
protocol-http (0.47.1)
protocol-http1 (0.28.1)
protocol-http (~> 0.22)
protocol-http2 (0.22.0)
protocol-hpack (~> 1.4)
protocol-http (~> 0.18)
racc (1.8.1)
rainbow (3.1.1)
rake (13.2.1)
regexp_parser (2.10.0)
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
rspec-mocks (~> 3.13.0)
rspec-core (3.13.2)
rspec-support (~> 3.13.0)
rspec-expectations (3.13.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-mocks (3.10.2)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.10.0)
rspec-support (3.10.2)
rubocop (1.13.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.2)
rubocop (1.69.2)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.0.0.0)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.2.0, < 2.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.36.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.5.0)
parser (>= 3.0.1.1)
rubocop-rake (0.5.1)
rubocop
rubocop-rspec (2.3.0)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.37.0)
parser (>= 3.3.1.0)
rubocop-performance (1.23.1)
rubocop (>= 1.48.1, < 2.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-rake (0.6.0)
rubocop (~> 1.0)
rubocop-ast (>= 1.1.0)
ruby-progressbar (1.11.0)
rubocop-rspec (3.3.0)
rubocop (~> 1.61)
ruby-progressbar (1.13.0)
simplecov (0.17.1)
docile (~> 1.1)
json (>= 1.8, < 3)
simplecov-html (~> 0.10.0)
simplecov-html (0.10.2)
unicode-display_width (2.0.0)
standard (1.43.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.69.1)
standard-custom (~> 1.0.0)
standard-performance (~> 1.6)
standard-custom (1.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.50)
standard-performance (1.6.0)
lint_roller (~> 1.1)
rubocop-performance (~> 1.23.0)
traces (0.14.1)
unicode-display_width (3.1.3)
unicode-emoji (~> 4.0, >= 4.0.4)
unicode-emoji (4.0.4)

PLATFORMS
arm64-darwin-24
x86_64-darwin-19

DEPENDENCIES
rake (~> 13.0)
rake (~> 13.2)
remoteok!
rspec (~> 3.0)
rubocop (~> 1.7)
rspec (~> 3.13)
rubocop (~> 1.69)
rubocop-performance
rubocop-rake
rubocop-rspec
simplecov (< 0.18)
simplecov (< 0.21)
standard (~> 1.31)

BUNDLED WITH
2.2.15
2.6.2
6 changes: 3 additions & 3 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
# frozen_string_literal: true

require 'bundler/gem_tasks'
require 'rspec/core/rake_task'
require "bundler/gem_tasks"
require "rspec/core/rake_task"

RSpec::Core::RakeTask.new(:spec)

require 'rubocop/rake_task'
require "rubocop/rake_task"

RuboCop::RakeTask.new

Expand Down
6 changes: 3 additions & 3 deletions bin/console
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
#!/usr/bin/env ruby
# frozen_string_literal: true

require 'bundler/setup'
require 'remoteok'
require "bundler/setup"
require "remoteok"

# You can add fixtures and/or initialization code here to make experimenting
# with your gem easier. You can also use a different console, if you like.
Expand All @@ -11,5 +11,5 @@ require 'remoteok'
# require "pry"
# Pry.start

require 'irb'
require "irb"
IRB.start(__FILE__)
4 changes: 2 additions & 2 deletions lib/remoteok.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true

require_relative 'remoteok/version'
require_relative 'remoteok/client'
require_relative "remoteok/version"
require_relative "remoteok/client"

# Module to interact with the RemoteOK API
module RemoteOK
Expand Down
Loading
Loading