Skip to content

Pin pre-commit version and align installation logic between bash and Windows setup scripts #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omsherikar merged 5 commits into from
Dec 22, 2025
Merged

Pin pre-commit version and align installation logic between bash and Windows setup scripts #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47c4b6d
Initial plan
Copilot Dec 18, 2025
03625fe
Make pre-commit installation consistent between bash and Windows scripts
Copilot Dec 18, 2025
89c81e1
Improve pre-commit check to include pip package verification
Copilot Dec 18, 2025
8463fae
Fix variable comparison syntax in Windows script
Copilot Dec 18, 2025
9d4228d
Pin pre-commit version in requirements-dev.txt for supply-chain security
Copilot Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ black>=23.0.0
mypy>=1.0.0
flake8>=6.0.0
isort>=5.12.0
pre-commit==4.5.1

# Documentation
sphinx>=7.0.0
Expand Down
5 changes: 0 additions & 5 deletions setup_dev.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@ if exist "requirements-dev.txt" (
REM Install pre-commit hooks
echo.
echo 🔧 Setting up pre-commit hooks...
python -m pip install pre-commit --quiet
if errorlevel 1 (
echo ❌ Error: Failed to install pre-commit
exit /b 1
)
pre-commit install
if errorlevel 1 (
echo ❌ Error: Failed to install pre-commit hooks
Expand Down
11 changes: 2 additions & 9 deletions setup_dev.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,8 @@ fi
# Install pre-commit hooks
echo ""
echo "🔧 Setting up pre-commit hooks..."
if command -v pre-commit &> /dev/null || pip show pre-commit &> /dev/null; then
pre-commit install
echo "✅ Pre-commit hooks installed"
else
echo "⚠️ pre-commit not found. Installing..."
pip install pre-commit --quiet
pre-commit install
echo "✅ Pre-commit hooks installed"
fi
pre-commit install
echo "✅ Pre-commit hooks installed"

# Verify installation
echo ""
Expand Down