Gui updates #1535
Gui updates #1535
Conversation
grilledham
left a comment
grilledham
left a comment
There was a problem hiding this comment.
Looks good. Thanks for cleaning up the code and updating the style etc.
Out of curiosity you mention in the PR that you "added some input sanitization where easily supported" but I couldn't spot what these changes were?
| numeric = true, | ||
| allow_decimal = false, | ||
| allow_negative = false, |
There was a problem hiding this comment.
Added native input sanitization for ammo count (the parsing logis was kept still, but this should give the user even more feedbacks as letters/commas cannot be used at all).
I havent checked if RedMew settings could use more of those but I havent heavily refactored that module (yet, dunno if it is needed) so maybe I'll come back to it in the future.
Next will be poll/player_list
| local function get_task_label_caption(task) | ||
| local caption = task.name | ||
| if #caption > label_max_length then | ||
| caption = caption:sub(1, label_max_length) .. ' [...]' | ||
| end | ||
| return table.concat { '#', task.task_id, ' ', caption } | ||
| end |
There was a problem hiding this comment.
Tasklist are capped at ~100 chars in the Tasks display list to prevent text flooding thee scroll pane.
The full text, editors, time of creation is now displayed for all tasks in their tooltip instead (which is cleaner)
RedRafe
left a comment
RedRafe
left a comment
There was a problem hiding this comment.
Left couple comments for ya @grilledham
Thanks, looks good. |
2 participants
Just a touch of restyling for our main GUIs of toolbar + file formatting to give every gui the same style/theme.
No logic changes.
Changes
Before/After of the changes