Skip to content

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Oct 6, 2025

This is a short PR that just adds the Dataset#category parameter and parses it/stores it without usage, as I want to make sure that we agree on category over categories: the latter, while more general, seems biologically useless.

@read-the-docs-community
Copy link

read-the-docs-community bot commented Oct 6, 2025

Documentation build overview

📚 spras | 🛠️ Build #31218800 | 📁 Comparing dc40e7f against latest (18f2cf8)


🔍 Preview build

No files changed.

@tristan-f-r tristan-f-r added the tuning Workflow-spanning algorithm tuning label Oct 6, 2025
@ntalluri
Copy link
Collaborator

ntalluri commented Oct 7, 2025

Could you update the config files so we can what the use of category label would look like? Also is a user now required to add a dataset category to each dataset they put in a config?

@tristan-f-r
Copy link
Collaborator Author

tristan-f-r commented Oct 7, 2025

The Optional tag in the schema means that category would be optional.

@tristan-f-r
Copy link
Collaborator Author

Could you update the config files so we can what the use of category label would look like?

I'll avoid this in the main config.yaml until we have sample data for a new dataset. I'll add accompanying documentation once we have some way to have runs only run on specific dataset categories.

@tristan-f-r tristan-f-r removed the tuning Workflow-spanning algorithm tuning label Oct 9, 2025
@agitter
Copy link
Collaborator

agitter commented Oct 10, 2025

I'm missing what we want to support with this category attribute. We want to list many datasets in a single config file and then somewhere else say only run on datasets where category=X? That was part of #309, but I'm not seeing the advantages of doing that all within a single config file.

@tristan-f-r
Copy link
Collaborator Author

This would be useful for cross-dataset-category analysis (i.e. unified statistics that check how well algorithms do on certain dataset categories than other categories). This is currently no longer useful for parameter tuning.

@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Jan 31, 2026
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants