-
Notifications
You must be signed in to change notification settings - Fork 25
fix: make dataset nodes ordering stable #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tristan-f-r
wants to merge
10
commits into
Reed-CompBio:main
Choose a base branch
from
tristan-f-r:generate-all-inputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
infrastructure
misc. changes made to SPRAS itself
needed for benchmarking
Priority PRs needed for the benchmarking paper
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main change:
spras/spras/dataset.py
Lines 107 to 108 in a61bfce
Some algorithms depend on the ordering of their nodes, which is why this is marked as needed for benchmarking: we can guarantee immutable generated outputs this way. We never want interactome permutations, as they don't produce immutable output for some algorithms.
This also adds tests to all inputs, closing #336.
This will be annoying to review. I have at least gone through and compared it with the regular input file to see that this looks right, but a thorough review of all of the test files will be unfortunately tedious.