feat(tickets): added child and student ticket types #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lornajane
reviewed
Apr 15, 2024
Contributor
lornajane
left a comment
lornajane
left a comment
There was a problem hiding this comment.
More examples are always valuable, thank you! I added some comments for minor alterations.
| get: | ||
| summary: List special events | ||
| description: Return a list of upcoming special events at the museum. | ||
| description: Return a list of past special events at the museum. See one you like? Use this API to [buy a ticket](/#tag/Tickets/operation/buyMuseumTickets). |
Contributor
There was a problem hiding this comment.
I think this should still be upcoming special events rather than past ones - we may need to add a date filter and/or some further-in-the-future events!
And the URL should be a full URL, so that the description markdown is useful in any context.
| schemas: | ||
| TicketType: | ||
| description: Type of ticket being purchased. Use `general` for regular museum entry and `event` for tickets to special events. | ||
| description: Type of ticket being purchased. Use `general` for regular museum entry and `event` for tickets to special events. Use `student` for school-aged children. Visitors aged 0-5 are free. |
Contributor
There was a problem hiding this comment.
For clarity, could we rephrase this to put the general, student and child tickets in one sentence, and the special event ones in another? I think it's age-related general entry, or an event ticket.
adamaltman
reviewed
Nov 20, 2024
Comment on lines
234
to
+238
| enum: | ||
| - event | ||
| - general | ||
| - student | ||
| - child |
Member
There was a problem hiding this comment.
What if a child or student goes to an event?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
It seemed like it would be a good idea to add museum ticket types for students (reduced price) and children aged 0-5 (free) so that there are a variety of ticket prices.
(Created as part of the Write The Docs writing conference Writing Day)
Check yourself
Security