Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the GitHub Actions test workflow to add an explicit per-test-process timeout to pytest invocations in order to prevent jobs from hanging indefinitely in CI. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider configuring the pytest timeout via
pytest.iniorpyproject.tomlinstead of hardcoding--timeout=180in the workflow so that local runs and other CI jobs inherit the same behavior consistently. - Ensure that the
pytest-timeoutplugin is installed in the test environment used by this workflow; otherwise the added--timeout=180flag will cause pytest to error rather than fixing the stuck test issue.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider configuring the pytest timeout via `pytest.ini` or `pyproject.toml` instead of hardcoding `--timeout=180` in the workflow so that local runs and other CI jobs inherit the same behavior consistently.
- Ensure that the `pytest-timeout` plugin is installed in the test environment used by this workflow; otherwise the added `--timeout=180` flag will cause pytest to error rather than fixing the stuck test issue.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 91.15% 91.21% +0.06%
==========================================
Files 38 38
Lines 2181 2185 +4
==========================================
+ Hits 1988 1993 +5
+ Misses 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
364b1e3 to
c571658
Compare
Member
Author
|
its difficult why sometime job stuck... I will figure out it latter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI: