Skip to content

Comments

Debug some time stuck issue#118

Open
digitronik wants to merge 1 commit intoRedHatQE:mainfrom
digitronik:debug_stuck_issue
Open

Debug some time stuck issue#118
digitronik wants to merge 1 commit intoRedHatQE:mainfrom
digitronik:debug_stuck_issue

Conversation

@digitronik
Copy link
Member

@digitronik digitronik commented Feb 4, 2026

Summary by Sourcery

CI:

  • Configure pytest invocations in the test workflow to use a 180-second timeout for each test run, both with and without coverage.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the GitHub Actions test workflow to add an explicit per-test-process timeout to pytest invocations in order to prevent jobs from hanging indefinitely in CI.

File-Level Changes

Change Details Files
Add explicit pytest timeout to CI test commands to prevent long-running or stuck test executions.
  • Extend the pytest command used for test runs with coverage to include a global timeout setting of 180 seconds.
  • Extend the pytest command used for test runs without coverage to include the same 180-second timeout setting.
  • Keep existing test options (parallelism, reruns, browser/pf-version matrix, coverage reporting) unchanged while augmenting them with the timeout flag.
.github/workflows/tests.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider configuring the pytest timeout via pytest.ini or pyproject.toml instead of hardcoding --timeout=180 in the workflow so that local runs and other CI jobs inherit the same behavior consistently.
  • Ensure that the pytest-timeout plugin is installed in the test environment used by this workflow; otherwise the added --timeout=180 flag will cause pytest to error rather than fixing the stuck test issue.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider configuring the pytest timeout via `pytest.ini` or `pyproject.toml` instead of hardcoding `--timeout=180` in the workflow so that local runs and other CI jobs inherit the same behavior consistently.
- Ensure that the `pytest-timeout` plugin is installed in the test environment used by this workflow; otherwise the added `--timeout=180` flag will cause pytest to error rather than fixing the stuck test issue.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.21%. Comparing base (98acfab) to head (c571658).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   91.15%   91.21%   +0.06%     
==========================================
  Files          38       38              
  Lines        2181     2185       +4     
==========================================
+ Hits         1988     1993       +5     
+ Misses        193      192       -1     
Flag Coverage Δ
unittests 91.21% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@digitronik
Copy link
Member Author

its difficult why sometime job stuck... I will figure out it latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant