Skip to content

Comments

Add playwright note and selenium legacy branch#115

Merged
digitronik merged 1 commit intoRedHatQE:mainfrom
digitronik:pw_note
Dec 15, 2025
Merged

Add playwright note and selenium legacy branch#115
digitronik merged 1 commit intoRedHatQE:mainfrom
digitronik:pw_note

Conversation

@digitronik
Copy link
Member

@digitronik digitronik commented Dec 15, 2025

Summary by Sourcery

Document Playwright as the default automation engine and point users to the legacy Selenium branch while updating the CI workflow to install the package in editable mode.

Build:

  • Switch CI test workflow to install the project in editable mode for development dependencies.

Documentation:

  • Add a README note clarifying that the main branch uses Playwright and directing users to the legacy Selenium support branch.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 15, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Switches local test installation to editable mode in the GitHub Actions workflow and documents the new Playwright-based main branch with a pointer to the legacy Selenium branch.

Flow diagram for branch usage: Playwright main vs Selenium legacy

flowchart TD
  start[Start: Choose browser automation stack]
  choice{Do you need legacy Selenium support?}
  main_branch[Use main branch\nPlaywright-based implementation]
  legacy_branch[Use legacy-selenium-support branch\nSelenium-based implementation]

  start --> choice
  choice -->|No| main_branch
  choice -->|Yes| legacy_branch
Loading

File-Level Changes

Change Details Files
Adjust test dependency installation in CI to use an editable install.
  • Change pip install command in the tests workflow from a regular install to an editable install for the project with dev extras
  • Ensure that CI tests run against the working tree code rather than a built distribution
.github/workflows/tests.yaml
Document Playwright as the primary automation engine and reference the legacy Selenium branch.
  • Add a prominent note that the main branch uses Playwright for browser automation
  • Provide a link and branch name for users who still need the legacy Selenium implementation
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Using pip install -e .[dev] in the CI workflow changes install semantics from a regular to an editable install; if this isn’t specifically needed (e.g., for live code edits during tests), consider keeping the non-editable install for more reproducible, production-like test environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Using `pip install -e .[dev]` in the CI workflow changes install semantics from a regular to an editable install; if this isn’t specifically needed (e.g., for live code edits during tests), consider keeping the non-editable install for more reproducible, production-like test environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.15%. Comparing base (a648080) to head (bf70cfd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main     #115       +/-   ##
==========================================
+ Coverage   0.00%   91.15%   +91.15%     
==========================================
  Files         37       38        +1     
  Lines       2118     2181       +63     
==========================================
+ Hits           0     1988     +1988     
+ Misses      2118      193     -1925     
Flag Coverage Δ
unittests 91.15% <ø> (+91.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@digitronik digitronik merged commit 7d5ca78 into RedHatQE:main Dec 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant