Add playwright note and selenium legacy branch#115
Merged
digitronik merged 1 commit intoRedHatQE:mainfrom Dec 15, 2025
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSwitches local test installation to editable mode in the GitHub Actions workflow and documents the new Playwright-based main branch with a pointer to the legacy Selenium branch. Flow diagram for branch usage: Playwright main vs Selenium legacyflowchart TD
start[Start: Choose browser automation stack]
choice{Do you need legacy Selenium support?}
main_branch[Use main branch\nPlaywright-based implementation]
legacy_branch[Use legacy-selenium-support branch\nSelenium-based implementation]
start --> choice
choice -->|No| main_branch
choice -->|Yes| legacy_branch
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Using
pip install -e .[dev]in the CI workflow changes install semantics from a regular to an editable install; if this isn’t specifically needed (e.g., for live code edits during tests), consider keeping the non-editable install for more reproducible, production-like test environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `pip install -e .[dev]` in the CI workflow changes install semantics from a regular to an editable install; if this isn’t specifically needed (e.g., for live code edits during tests), consider keeping the non-editable install for more reproducible, production-like test environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 0.00% 91.15% +91.15%
==========================================
Files 37 38 +1
Lines 2118 2181 +63
==========================================
+ Hits 0 1988 +1988
+ Misses 2118 193 -1925
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Document Playwright as the default automation engine and point users to the legacy Selenium branch while updating the CI workflow to install the package in editable mode.
Build:
Documentation: