feat(host-inventory): restructure to generate into src directory#429
Closed
OlhaTmlk wants to merge 1 commit intoRedHatInsights:mainfrom
Closed
feat(host-inventory): restructure to generate into src directory#429OlhaTmlk wants to merge 1 commit intoRedHatInsights:mainfrom
OlhaTmlk wants to merge 1 commit intoRedHatInsights:mainfrom
Conversation
Align host-inventory package with notifications/integrations build pattern: generate TypeScript into src/, add clean-generate and clean-build targets, update tsconfig to target ES2021 for ESM. Regenerated from current OpenAPI spec with new endpoints added: - ApiHostGroupGetHostListByGroup - ApiHostViewsGetHostViews
OlhaTmlk
force-pushed
the
RHCLOUD-43171
branch
from
ead8a65 to
2a24e7f
Compare
charlesmulder
requested changes
Feb 25, 2026
Contributor
charlesmulder
left a comment
charlesmulder
left a comment
There was a problem hiding this comment.
The code changes look correct. One small thing, I think this might be better classified as a feat, since it introduces two new endpoints to the client. That would align with a minor version increment.
OlhaTmlk
changed the title
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align host-inventory package with notifications/integrations build
pattern: generate TypeScript into src/, add clean-generate and
clean-build targets, update tsconfig to target ES2021 for ESM.
Regenerated from current OpenAPI spec with new endpoints added: