Skip to content

Oct 2022 "integration test"#3

Closed
RedFlames wants to merge 25 commits intomainfrom
oct-2022-integration-test
Closed

Oct 2022 "integration test"#3
RedFlames wants to merge 25 commits intomainfrom
oct-2022-integration-test

Conversation

@RedFlames
Copy link
Owner

@RedFlames RedFlames commented Sep 30, 2022 •
edited
Loading

Branch with all outstanding client fixes merged in. I guess it's... a release candidate?

git checkout main
git checkout -b oct-2022-integration-test

git merge pingfix-playerlist             # PR 28
git merge upstream/ghost-fixes           # PR 29

# include suggestions brought up in PR 29
nano CelesteNet.Client/Components/CelesteNetMainComponent.cs
nano CelesteNet.Client/Components/CelesteNetMainComponent.cs
git commit -a -m "PR #29 suggested fixes"

git merge misc-rendering-fixes           # PR 30
git merge grab-release-fix               # PR 31
git merge ui-keyboard-entry-chat-bugfix  # PR 35
git merge emote-timeskip-fixes           # PR 39
git merge chat-component-client-null     # PR 41
git merge hair-length-fix                # PR 43

Edit: As of 2022-10-08 jade has merged all of these except for 0x0ade#29 upstream. 👍

RedFlames and others added 25 commits April 18, 2022 00:54
@RedFlames
Fixes for Player list ping updates:
55cfc64 
 * only show ping for player's own channel in channel view

 * no need to rebuild much of the list, since split lists will not be affected

 * fix minor oversight in that toggling list splitting on/off in settings didn't force rebuild list
@RedFlames
Change 'Spoofed' placeholder to '???ms' on invalid ping data.
b2e9467
@RedFlames
Use an expression-body property for Settings.PlayerListAllowSplit lik…
9404249 
…e with the other settings.
Fix ghost life cycle edge cases
3f10a19
@RedFlames
Check for (BlurRT != null) in CelesteNetRenderHelperComponent.cs
b04ac86
@RedFlames
This List?.First(...) should've been a FirstOrDefault() since it shou…
ea9d15d 
…ld return null and not throw anything when there's no elements.
@RedFlames
Replace the Fonts.Load() with a Fonts.Get() in CelesteNetClientFontMo…
8adda05 
…no.cs to avoid calling Emoji.Fill() whenever the font is used e.g. for rendering.
@RedFlames
Didn't realize one call to Load will be needed. No idea why I thought…
924fe3a 
… taking it out worked; turns out it didn't.
@RedFlames
Fix non-interactive players always responding with 'release me' packe…
b458760 
…ts when receiving any grab packet.
Fix GravityHelper issue
f80b8f0
@RedFlames
Prevent chat from opening if keyboard is used for text entry dialogs,…
7e6b740 
… like OuiFileNaming and OuiModOptionString.
@RedFlames
TODO: not detecting end of EH cutscene properly yet.
26c344c
@RedFlames
Introduced Delay before removing EmptySpaceHeart from TimeRateSkip si…
d2a8096 
…nce there's at least a few frames between the Gem triggering and the cutscene starting. Without the delay, the Wheel's Update would remove EmptySpaceHeart right away.
@RedFlames
Prevent chat component NREs when Client is null
abeaaf5
@RedFlames
Resend graphics when hair length change detected, and stop hair sim o…
6867414 
…n idle (pause)
@RedFlames
Remove hair debug stuff
aef046e
@RedFlames
Merge branch 'pingfix-playerlist' into oct-2022-integration-test
cf7a07c
@RedFlames
Merge remote-tracking branch 'upstream/ghost-fixes' into oct-2022-int…
77e65f2 
…egration-test
@RedFlames
PR 0x0ade#29 suggested fixes
3eda670
@RedFlames
Merge branch 'misc-rendering-fixes' into oct-2022-integration-test
8dc98d6
@RedFlames
Merge branch 'grab-release-fix' into oct-2022-integration-test
78bc531
@RedFlames
Merge branch 'ui-keyboard-entry-chat-bugfix' into oct-2022-integratio…
f1008ef 
…n-test
@RedFlames
Merge branch 'emote-timeskip-fixes' into oct-2022-integration-test
7409754
@RedFlames
Merge branch 'chat-component-client-null' into oct-2022-integration-test
e42244d
@RedFlames
Merge branch 'hair-length-fix' into oct-2022-integration-test
d98ae3c
@RedFlames
Copy link
Owner Author

RedFlames commented Oct 9, 2022

Almost all in main branch now, except 0x0ade#29 + 3eda670

@RedFlames RedFlames closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RedFlames