Conversation
FormattedLogValues are made internal and do not work anymore.
siderisltd
left a comment
There was a problem hiding this comment.
This is better than the other solution with getting the Microsoft classes as it's not breaking the TState when you want to log model
siderisltd
left a comment
There was a problem hiding this comment.
Please remove the usage of Microsoft.Extensions.Logging.Externals namespace used in the solution.
|
Where exactly? I cannot find where "Microsoft.Extensions.Logging.Externals" are used in the solution. |
|
Sorry @kostas-baltsoft @kostelis, my bad - it's using Microsoft.Extensions.Logging.Internal; which is not longer available. You can see my commit where I added the original files initially. -> #5 Also in your method GetFirstValue - the field may be null so I strongly recommend you adding a null check. I've hit that while I was testing From To @cpwood can we merge his request once these changes are applied? |
|
Hey guys, sorry for a late reply. I have implemented a possible null reference check. |
FormattedLogValues are made internal and do not work anymore.