Enhanced sort feature to enable user to click on the column header th… #76
Conversation
Tejas-ChandraShekarRaju
requested review from
DeRaowl,
Neha,
pallabez and
prakashchoudhary07
| /> | ||
| )} | ||
|
No newline at end of file |
||
| return <Table featureFlags={featureFlags} headers={headers} />; |
There was a problem hiding this comment.
can we just make use of arrow function here? No need to write return explicitly
There was a problem hiding this comment.
Same is followed everywhere. This is not a change from this PR. It shows it changed because i ran perttier. Let me know if you still need me to change it because all components follow the same
There was a problem hiding this comment.
Ok, we can change this to arrow function
| ? a[key].toUpperCase() : a[key]; | ||
| const varB = (typeof b[key] === 'string') | ||
| ? b[key].toUpperCase() : b[key]; | ||
| const varA = typeof a[key] === "string" ? a[key].toUpperCase() : a[key]; |
There was a problem hiding this comment.
Can we have better naming for variable varA and varB doesn't describe it's purpose
There was a problem hiding this comment.
Hi @DeRaowl this is a comparator function. What do you think would be better? Since those are keys can i name them key1 and key2?
There was a problem hiding this comment.
Ok instead you can just add small comment saying what these variables are
| /> | ||
| )} | ||
|
No newline at end of file |
||
| return <Table featureFlags={featureFlags} headers={headers} />; |
There was a problem hiding this comment.
Ok, we can change this to arrow function
| ? a[key].toUpperCase() : a[key]; | ||
| const varB = (typeof b[key] === 'string') | ||
| ? b[key].toUpperCase() : b[key]; | ||
| const varA = typeof a[key] === "string" ? a[key].toUpperCase() : a[key]; |
There was a problem hiding this comment.
Ok instead you can just add small comment saying what these variables are
3 participants
Fixes (#69)
Enhancement
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: