-
Notifications
You must be signed in to change notification settings - Fork 7
new feature notifications in UI completed with styling and tests #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
new feature notifications in UI completed with styling and tests #53
Conversation
harshith-venkatesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR, minor changes are requested
Neha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Can we discuss this over a call?
756b7de to
7d48924
Compare
Neha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP review
dbe95c2 to
4213a19
Compare
|
@ivinayakg could you please resolve the conflict file? So, that we can merge this branch |
Description
I created a system for notifications throughout the react application.
You get two main things from the main file one is a react component which has to be rendered on the top of the stack with given a prop of timeout(time you want to show a notification for) which defaults to 2000ms. Second is a simple javascript function NotificationHandler which can be called from anywhere from the entire app with a data object which would be:-
The color of the notification would be based upon the "type" of the data object. right now the color would be shown as the background of the notification but as we decide what kind of icon library or solution we would be using then in the future only the icon with the associated color and message from the data will be rendered. The demo of the feature is as below.
Fixes #30
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: