Fix #641 #645
Merged
Fix #641 #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReagentX
added
bug
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #641 by correcting invalid HTML syntax in the HTML exporter. The changes address two types of HTML syntax errors: commas incorrectly placed between HTML attributes (which are invalid in HTML) and missing closing angle brackets on opening HTML tags. These corrections ensure the generated HTML is valid and will render correctly in browsers.
Key Changes:
- Removed extraneous commas between HTML attributes (e.g.,
class="message", id="..."→class="message" id="...") - Fixed incomplete opening tags by adding missing closing angle brackets (e.g.,
type="audio" </audio>→type="audio"> </audio>) - Updated test assertions to match the corrected HTML output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.