Skip to content

No error should be shown when links are deleted #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rps wants to merge 1 commit into
base: master
Choose a base branch
from
Open

No error should be shown when links are deleted #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions public/js/controllers/formController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ controllers.controller('FormController', ['$scope', '$http', '$modal', '$q', 'ta
$scope.getSuggestedData = function(link) {
var urlRegEx = /(http|https|ftp):\/\/[-a-zA-Z0-9@:%_\+.~#?&\/\/=]{2,256}\.[a-z]{2,4}\b(\/[-a-zA-Z0-9@:%_\+.~#?$&\/\/=]*)?/gi;

//No error message if no link
if(link.length === 0){
$scope.suggestedData = '';
return;
}

//If entered data doesn't match the URL regex, then return error data, and don't actually make the AJAX request.
if (!urlRegEx.test(link)) {
var badURL = {warning: "Snap! That link came back with nothing. How about pasting it in?", tags: []};
Expand Down