fixing netlist generation for elementary pcells #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adityakak27
commented
Jan 25, 2026
adityakak27
commented
- mappedpdk now handles strings and netlist objects both (since lvcm requires netlists, and others may generate string obj)
- all import paths for pcells in ATLAS/ directory have been fixed, and drc/lvs runs clean.
AL-255
suggested changes
Jan 31, 2026
| component = component_snap_to_grid(rename_ports_by_orientation(top_level)) | ||
| component.info['netlist'] = low_voltage_cmirr_netlist(bias_fvf, cascode_fvf, fet_1_ref, fet_2_ref, fet_3_ref, fet_4_ref) | ||
| netlist_obj = low_voltage_cmirr_netlist(bias_fvf, cascode_fvf, fet_1_ref, fet_2_ref, fet_3_ref, fet_4_ref) | ||
| component.info['netlist'] = netlist_obj.generate_netlist() |
Contributor
There was a problem hiding this comment.
I would advise keeping the original 'netlist' key for the netlist object (to avoid changing a bunch of other cells and breaking things). How about 'netlist_text' or 'netlist_spice'
Contributor
There was a problem hiding this comment.
This is a good cleanup of the existing code.
What still needs to be done: remove current_mirror.py, diff_pair.py, fvf.py, lvcm.py, opamp.py, transmission_gate.py. They're duplicates of what's in the upper level, created as a temporary hack.
Please commit the same changes to those files, and remove them from the ATLAS folder completely.
After this, we can look at Erin's PR #70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.