Added JSON for proper netlisting #69
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous parameters). The previous version failed since it likely stored everything as string. This change can successfully run on the generate_sample files.
Contributor
|
Hi Patel, can you update the description of this PR? |
Author
|
I said we shouldn't merge it because when I tried running this code on gLayout, it would not netlist properly. This code was tailored for OpenFASOC, and specifically for running/collecting sample data. This was a quick fix that allowed us to run samples. However, when transferred into this directory, it does not work. However, last week, you and Saptarshi decided that we should merge it anyway because Nimish's new PR also follows a similar structure to mine. Let me know if you have other questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JSON since it is better for structured data(like nodes and varous parameters). The previous version failed since it likely stored everything as a string. This change can successfully run on the "generate_sample" files.