Add polyresistor primitive with GF180MCU support #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ErinXU2004
commented
Oct 14, 2025
ErinXU2004
commented
- Add polyres.py: polyresistor primitive implementation
- Update gf180_mapped.py: add polyresistor models and layers
- Update gf180_grules.py: add polyresistor design rules
- Update mappedpdk.py: add polyresistor layer validation
- Polyresistor supports both silicided and unsilicided types
- DRC clean on kLayout
- Add polyres.py: polyresistor primitive implementation - Update gf180_mapped.py: add polyresistor models and layers - Update gf180_grules.py: add polyresistor design rules - Update mappedpdk.py: add polyresistor layer validation - Clean branch based on upstream/main (no docker_testing folder) - Polyresistor supports both silicided and unsilicided types - Includes proper netlisting and DRC compliance
Collaborator
|
|
msaligane
reviewed
Nov 7, 2025
- Move test code from polyres.py to dedicated test folder - Create tests/regression/test_polyres_multifinger.py with parameterized tests - Add comprehensive test coverage for M1.2a spacing fix - Include tests for various widths (0.5, 0.8, 1.0, 1.5 µm) - Include tests for various finger counts (2, 3, 5, 7) - All tests are fully parameterized and configurable - Add detailed README.md with usage examples - Addresses code review request to add tests to regression test folder
- Clean up ATLAS-related files from blocks/ATLAS directory - These files were specific to dataset generation workflow - Keep repository focused on core gLayout functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.