Skip to content

Adds instance cache to expensive operation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pet1330 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Adds instance cache to expensive operation #16

pet1330 wants to merge 3 commits into from

Conversation

@pet1330
Copy link
Collaborator

@pet1330 pet1330 commented Nov 19, 2020

No description provided.

@pet1330 pet1330 added the Needs testing This issue or pull request needs testing label Nov 19, 2020
@RaymondCM
Copy link
Owner

RaymondCM commented Nov 19, 2020

This looks good so far, the only thing I would suggest is that we make def __dict_to_ros_msg_dict(data_dict, ): and def __ros_msg_dict_to_list(ros_msg_dict, return_keys=False, parent=""): class functions and also cache these because they are called by .msgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs testing This issue or pull request needs testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pet1330 @RaymondCM