Use environmental variables for docker-compose

[rugk]

• You can start it as usual, .env file is automatically used.
• IMHO easier and cleaner to configure.
• Also removed the <host> as it makes this not-runnable out-of-the-box. I need this for Create OWASP security scan of Docker container #69 and this was the initial idea of making this PR.
• The ${:?} syntax is a bash-like thing to produce a proper error message if the variable is not provided.

I checked the setup should basically start (just got a permission error as the UID/GID is wrong).

[Ravinou]

Hi! I'm not in favor of using an .env file for docker-compose. If people want to do it, they are free to do it, but for the example it makes the installation more "complex" and it doesn't allow to show the indispendable variables anymore. It's less "out-of-the-box".

If we're going to integrate OWASP (which I think is a good idea), I'd like to adapt the OWASP config without affecting the readability of how to run borgwarehouse.

[rugk]

Hmm, IMHO it's easier though…

it makes the installation more "complex"

Well you have two files now, but you only need to touch one file anyway? I would not call that too complex…

doesn't allow to show the indispendable variables anymore

Hmm how do you mean that? IMHO it is easier to see and adjust all the variables you need as you can basically just cat .env respectively see them. You also have various ways to pass/use different ones and you can obviously even omit the .env file and pass all variables as system .env variables. So IMHO, this is more flexible (which I needed for my use case).

[Ravinou]

@rugk ok you convinced me :)
Anyway, it's true that secrets should always be in an env file rather than a conf file, it's a better practice.

[rugk]

Okay great, then well… you'd need to approve and merge this, don't you? 🙃

BTW secret management is a huge topic and there are a lot of solutions for that too, but IMHO that would be a next topic and maybe even just be too much for this simple docker-compose.yml for now, so maybe env variables are better (as you can choose how and where to pass them) than before after all though.

[Ravinou]

Okay great, then well… you'd need to approve and merge this, don't you? 🙃

Can you just please check my comments in review and modify your PR ? Thank you

[rugk]

I see no comments, is your review maybe still pending? You need to submit it to submit all the comments… 🙃

[Ravinou]

I see no comments, is your review maybe still pending? You need to submit it to submit all the comments… 🙃

No comment ... it's done 😂😂😂

[rugk]

@Ravinou any news? 👀

[Ravinou]

@rugk Sorry for the delay, difficult end of year for me.

Thanks it's merged on the develop branch. It will be part of the next release in the next few days.