Skip to content

Improvements to shield checking #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rptb1 wants to merge 1 commit into from
Closed

Improvements to shield checking #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions code/seg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@ static void segAbsFinish(Inst inst)

AVERT(Seg, seg);

RingRemove(SegPoolRing(seg));

arena = PoolArena(SegPool(seg));

/* TODO: It would be good to avoid deprotecting segments eagerly
Expand All @@ -205,6 +203,11 @@ static void segAbsFinish(Inst inst)
ShieldFlush(PoolArena(SegPool(seg)));
AVER(!seg->queued);

/* shieldDebugCheck requires SegFirst/SegNext to find all segments,
so the segment must remain on the pool ring until shield
operations are complete. */
RingRemove(SegPoolRing(seg));

limit = SegLimit(seg);

TRACT_TRACT_FOR(tract, addr, arena, seg->firstTract, limit) {
Expand Down