Adds ORSO validation tests #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenNneji
reviewed
May 9, 2025
Contributor
StephenNneji
left a comment
StephenNneji
left a comment
There was a problem hiding this comment.
Looks good, Please see comments
StephenNneji
approved these changes
May 9, 2025
Contributor
There was a problem hiding this comment.
Please add the script that generates the json to the test_data folder also
StephenNneji
reviewed
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
ORSO tests are included through definition of a python project and running a full calculation. Note that the setup of the fixture in this test does take ~2mins (hence the modular scope).