More useful Channels in Rust #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
send, without passing Tether Agent ref to channel or channel to Tether Agent
not typed at ChannelSender level!)
…atching results in correct type
…ns - both from tether_agent instance
… TetherAgent itself
…els via TetherAgent instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing Tether Agent references to channel instances, and Channel references to Tether Agent instances, why not connect them much more "automatically"?
The idea would be to create ChannelSender and ChannelReceivers which are strictly typed (using Generics) so that encoding+sending and receiving+decoding happens directly through the Channels themselves, not manually.