Improve errors in rmc_assemble #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still not a massive fan of how we're handling errors but it's okay
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling in the assembler by adding line number information to parse errors and providing better error messages for I/O operations.
- Refactored
ParseErrorto include line numbers and separate error types from context - Added
ReadErrorandWriteErrorvariants toAssemblerErrorfor better I/O error handling - Changed
mainfunction return type fromResult<(), String>toResult<(), AssemblerError>for consistent error handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/rmc_assemble.rs | Enhanced error handling with line numbers in parse errors, added I/O error variants, and improved error display formatting |
| demos/tests/invalid.lmc | Added test file with invalid opcode to demonstrate error reporting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.