Clippy: Fix result_large_err by boxing redb errors #456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Typically you'd address this lint by boxing the error. Is there a reason we shouldn't do that here? |
Collaborator
Author
|
No particular reason from me. I don't have a good sense of how much we care about the error sizes, and I didn't expect that it would be a bottleneck, so I went with the easiest approach (of not changing the code). I also checked the redb examples, and they also took this shortcut (https://github.com/cberner/redb/pull/974/files). Boxing the error does seem better though. I need to figure out how to do this in an idiomatic way that interacts with thiserror. 160 bytes is indeed very big. EDIT: PR updated to stop ignoring errors. I'm not sure if there's a more idiomatic way of doing this. |
Errors from redb are 160 bytes long, which could potentially cause unexpected overhead.
patowen
force-pushed
the
allow-result-large-error
branch
from
e9d4fe7 to
0234eb3
Compare
patowen
changed the title
Ralith
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReadTransactionStillInUseerror variant of the redb error type is 160 bytes long, with most of its size coming from theredb::tree_store::TableTreetype.An alternative implementation would be to ignore the error or add a "clippy.toml" to increase the error threshold to 161, but 160 bytes is quite long for a
Resulttype, so boxing the error would likely be the better design.Note (for anyone reading the comment thread): This PR is a revised version of a PR that initially just ignored the clippy lint in the places it triggered from.