Merged
Conversation
- Assert title is not null before string assertions in TestSEO - Add native union type to HTMLParser::grabMultiple() parameter - Replace implicit empty array falsy check with explicit comparison in SimpleSerializer::formatTagCollection() - Skip items with missing keys in ArrayPluck instead of crashing Changelog: fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSEO: null checks en assertions de título
assertTitleContains()yassertTitleEndsWith()ahora comprueban que el título no sea null antes de las aserciones de stringHTMLParser: tipo nativo en grabMultiple()
$attributetipado comostring|array|null(antes sin tipo)SimpleSerializer: check explícito en formatTagCollection()
?: null(falsy implícito) por=== []explícito para distinguir correctamente entre colecciones vacías y colecciones con valoresArrayPluck: validación de estructura
Test plan