Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • cleanup unity telemetry logging

@StephenHodgson StephenHodgson marked this pull request as ready for review December 14, 2025 18:37
Copilot AI review requested due to automatic review settings December 14, 2025 18:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up Unity telemetry logging by refactoring the UTP (Unity Test Platform) type system, improving JSON sanitization to handle ANSI color codes, and enhancing log parsing with proper partial-line handling. The version is bumped to 1.8.1.

  • Refactored UTP type definitions into a dedicated module with comprehensive type coverage and validation
  • Enhanced telemetry JSON sanitization to handle ANSI escape sequences and properly process partial log lines
  • Updated GitHub Actions workflows with latest action versions and improved configuration

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/utp/utp.ts New file containing expanded UTP type definitions with normalization and validation logic
src/utp.ts Removed - types migrated to src/utp/utp.ts
src/unity-logging.ts Refactored telemetry parsing with ANSI handling, partial line buffering, and improved sanitization
tests/unity-logging.test.ts Added test for ANSI color code removal in telemetry JSON
src/logging.ts Added comment clarifying UTP as minimal logging level
src/cli.ts Removed unused options parameter from editor-logs command
package.json Version bump to 1.8.1 and @types/node update
package-lock.json Lockfile updates for dependencies
.github/workflows/unity-build.yml Updated to actions/checkout@v6, improved shell configuration, and workflow cleanup
.github/workflows/publish.yml Updated to actions/checkout@v6
.github/workflows/integration-tests.yml Updated to actions/checkout@v6

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StephenHodgson StephenHodgson merged commit 89e7372 into main Dec 16, 2025
142 of 145 checks passed
@StephenHodgson StephenHodgson deleted the development branch December 16, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant