Conversation
jdmarshall
force-pushed
the
devcontainer
branch
3 times, most recently
from
d65a553 to
1f6f8c4
Compare
RafaelGSS
reviewed
Jan 22, 2026
RafaelGSS
reviewed
Jan 27, 2026
| @@ -0,0 +1,3 @@ | |||
| FROM node:24.6-trixie-slim | |||
Owner
There was a problem hiding this comment.
Can we avoid fixing a semver-minor version? What about node:24-alpine only?
Collaborator
Author
There was a problem hiding this comment.
Not with the outstanding issue with commandline flags and tests.
RafaelGSS
reviewed
Jan 29, 2026
Owner
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
You should rebase and keep only the devcontainer.json changes. Feel free to land it once you remove the two unrelated commit.
jdmarshall
force-pushed
the
devcontainer
branch
from
3d10f70 to
f60752a
Compare
Also 24.6 is the last node version that honors the nodejs CLI flags.
jdmarshall
force-pushed
the
devcontainer
branch
from
f60752a to
f027a5b
Compare
Collaborator
Author
|
I could have sworn you merged that other commit. Weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While npmjs.org is trying to take important steps to reduce supply chain attacks, working with, or indeed on, other people's OSS projects is still a bit fraught at the moment.
While dev containers are really meant for more elaborate workflows, a barebones implementation seems to be pretty okay for isolating
npm installfrom having access to things it should not have access to.