Skip to content

Add benchmark summary#10

Merged
Rac75116 merged 3 commits intomainfrom
developing
Dec 21, 2025
Merged

Add benchmark summary#10
Rac75116 merged 3 commits intomainfrom
developing

Conversation

@Rac75116
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings December 21, 2025 06:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds benchmark visualization and documentation to the repository, along with a minor spelling fix in the test code.

  • Adds a comprehensive benchmark summary table showing performance metrics across different bit widths
  • Integrates benchmark results into the README with visualizations
  • Fixes typo in test file from "currect_file" to "current_file"

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.

File Description
tests/isprime_tests.cpp Corrects spelling error in variable name from "currect_file" to "current_file"
bench_results/bench_summary.md Adds new benchmark summary table with performance data for IsPrime and IsPrimeNoTable functions across 64 bit widths
README.md Adds GitHub Actions badge, new Benchmarks section with links to detailed results and embedded benchmark visualizations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to 2
| Bit Width | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) |
|-----------|-----------------------|------------------------------|-----------------------|------------------------------|
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table header has duplicate column names "IsPrime Avg Time (ns)" and "IsPrimeNoTable Avg Time (ns)" appearing twice. This makes it unclear what each column represents. Consider adding descriptive labels to distinguish between the two sets of columns, such as specifying what condition or dataset each pair of columns represents (e.g., "Primes" vs "Composites", or different test scenarios).

Suggested change
| Bit Width | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) |
|-----------|-----------------------|------------------------------|-----------------------|------------------------------|
| Bit Width | IsPrime Avg Time (ns, Test 1) | IsPrimeNoTable Avg Time (ns, Test 1) | IsPrime Avg Time (ns, Test 2) | IsPrimeNoTable Avg Time (ns, Test 2) |
|-----------|------------------------------|---------------------------------------|------------------------------|---------------------------------------|

Copilot uses AI. Check for mistakes.
README.md Outdated

![](https://github.com/Rac75116/libcpprime/actions/workflows/tests.yml/badge.svg)

**libcpprime** is a efficient C++ implementation of a primality test optimized for 64-bit integers.
Copy link

Copilot AI Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error: "a efficient" should be "an efficient" since "efficient" starts with a vowel sound.

Suggested change
**libcpprime** is a efficient C++ implementation of a primality test optimized for 64-bit integers.
**libcpprime** is an efficient C++ implementation of a primality test optimized for 64-bit integers.

Copilot uses AI. Check for mistakes.
@Rac75116 Rac75116 merged commit dd1f49d into main Dec 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant