Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds benchmark visualization and documentation to the repository, along with a minor spelling fix in the test code.
- Adds a comprehensive benchmark summary table showing performance metrics across different bit widths
- Integrates benchmark results into the README with visualizations
- Fixes typo in test file from "currect_file" to "current_file"
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/isprime_tests.cpp | Corrects spelling error in variable name from "currect_file" to "current_file" |
| bench_results/bench_summary.md | Adds new benchmark summary table with performance data for IsPrime and IsPrimeNoTable functions across 64 bit widths |
| README.md | Adds GitHub Actions badge, new Benchmarks section with links to detailed results and embedded benchmark visualizations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bench_results/bench_summary.md
Outdated
| | Bit Width | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) | | ||
| |-----------|-----------------------|------------------------------|-----------------------|------------------------------| |
There was a problem hiding this comment.
The table header has duplicate column names "IsPrime Avg Time (ns)" and "IsPrimeNoTable Avg Time (ns)" appearing twice. This makes it unclear what each column represents. Consider adding descriptive labels to distinguish between the two sets of columns, such as specifying what condition or dataset each pair of columns represents (e.g., "Primes" vs "Composites", or different test scenarios).
| | Bit Width | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) | IsPrime Avg Time (ns) | IsPrimeNoTable Avg Time (ns) | | |
| |-----------|-----------------------|------------------------------|-----------------------|------------------------------| | |
| | Bit Width | IsPrime Avg Time (ns, Test 1) | IsPrimeNoTable Avg Time (ns, Test 1) | IsPrime Avg Time (ns, Test 2) | IsPrimeNoTable Avg Time (ns, Test 2) | | |
| |-----------|------------------------------|---------------------------------------|------------------------------|---------------------------------------| |
README.md
Outdated
|
|
||
|  | ||
|
|
||
| **libcpprime** is a efficient C++ implementation of a primality test optimized for 64-bit integers. |
There was a problem hiding this comment.
Grammatical error: "a efficient" should be "an efficient" since "efficient" starts with a vowel sound.
| **libcpprime** is a efficient C++ implementation of a primality test optimized for 64-bit integers. | |
| **libcpprime** is an efficient C++ implementation of a primality test optimized for 64-bit integers. |
No description provided.