Cherry-pick - ROCm 7.2.X: Bugfixes and updates #689
+1,308
−732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* * rocDecode: Added logging control - Message output from the core components is now controlled by the logging level, which can be set by an environment variable or other methods. * * rocDecode/Logging control: Fixed a typo. * * rocDecode/Logging control: Removed reference to the logger class from RocVideoDecoder utility, which results in build error on non-source install environment. * * rocDecode/Logging control: Improved some wording in the docs.
- Fixed the build error with videodecodepicfiles sample. - Added error handling of sample app command option combination of memory type OUT_SURFACE_MEM_NOT_MAPPED and MD5 generation.
* rocDecode host - Package * Host Package - Added * Readme - Host updates * Changelog - Updates
* Updated core docs + Doxyfile * fixed issues, renamed a file, deleted unused files * added hip-dev as a requirement for 7.2 * updated with Jeff's review * updated getvideoframe description * Update docs/reference/rocDecode-parser.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * Update docs/how-to/using-rocDecode-video-decoder.rst Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com> * updated with Leo's feedback * fixed a wrong link in toc --------- Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com>
* Tests and samples - bugfixes * CMakeLists - add CMAKE_MODULE_PATH * Fix header - Host * Host - decouple * Host Utils - Reset * Test - enable advanced test with host lib
* Host decouple - samples and test * Host - install utils with dev * Host - Install host files in core temp
* Add support for TheRock compatibility * Update the version * code clean up * clean up
* Add ${CMAKE_CURRENT_SOURCE_DIR} over ${CMAKE_SOURCE_DIR} where required
* Address review comments
* TheRock compatibility - Devicelib Support * clean up
…ode-host from it (#685) * Add rocdecDecode to the ctest and decouple the rocdecode-host from it * clean up
…687) * * rocDecode: Fixed the incorrect MD5 results when user crop is enabled. - When the user cropping is enabled, the cropping rect needs to be sent to the output surface info struct, which is used by the MD5 calculation. * * rocDecode: Minor change based on review comment.
* * rocDecode/rocdecdecode sample: Fixed the crash issue on AVC streams. - We need to set bit depth to 8 when creating the initial decoder. This allows all codec types to be accommodated. Other bit depths can be supported in decoder reconfig later. * * rocDecode/rocdecdecode sample: Changed program stop from harsh abort to graceful exit, when critial error occurs. * * rocDecode/rocdecdecode sample: Minor change based on review comment.
kiritigowda
requested review from
AryanSalmanpour and
rrawther
as code owners
AryanSalmanpour
approved these changes
Jan 12, 2026
LakshmiKumar23
approved these changes
Jan 12, 2026
rrawther
approved these changes
Jan 12, 2026
spolifroni-amd
approved these changes
Jan 14, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/rocm-rel-7.2 #689 +/- ##
========================================================
- Coverage 88.08% 87.92% -0.16%
========================================================
Files 28 28
Lines 10614 10656 +42
========================================================
+ Hits 9349 9369 +20
- Misses 1265 1287 +22
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
RM approval required for merge
Motivation
Required changes to fix version mismatch in FFmpeg between build and target systems
Technical Details
Building rocdecode package on AlmaLinux/ManyLinux to launch packages on target devices with other flavor of linux will create issues with version of FFmpeg
Fix is separate the host and device packages, with samples to support tests for target without FFmpeg
Test Plan
CTest
Test Result
All tests should pass
Submission Checklist