Closed
Conversation
eddieliao
approved these changes
Jan 13, 2026
eddieliao
left a comment
eddieliao
left a comment
There was a problem hiding this comment.
LGTM, an additional comment would be nice but isn't a blocker.
TedThemistokleous
approved these changes
Jan 13, 2026
Collaborator
TedThemistokleous
left a comment
TedThemistokleous
left a comment
There was a problem hiding this comment.
This change will only be on the rocm side of things. You'll need to retarget this for the recent rocm7.2_internal_testing branch if this issue is seen for 7.2 builds as thats where DLM will pull from
causten
requested changes
Jan 20, 2026
Collaborator
causten
left a comment
causten
left a comment
There was a problem hiding this comment.
Also switch the branch to rocm7.2_internal_testing
| # BERT | ||
| "bert-base-cased": (["input_ids", "attention_mask", "token_type_ids"], 16, False, "bert"), | ||
| "bert-base-cased": (["input_ids", "attention_mask", "token_type_ids"], 18, False, "bert"), | ||
| "bert-large-cased": (["input_ids", "attention_mask", "token_type_ids"], 16, False, "bert"), |
Collaborator
There was a problem hiding this comment.
Don't you also need to change this one to 18 ?
Collaborator
|
Change already done on rocm7.2_internal_testing. Closing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.