Skip to content

Comments

Always use V2 hipify. Make all hipify results consistent#459

Draft
ipanfilo wants to merge 1 commit intodevfrom
ipanfilo/hipify_unification
Draft

Always use V2 hipify. Make all hipify results consistent#459
ipanfilo wants to merge 1 commit intodevfrom
ipanfilo/hipify_unification

Conversation

@ipanfilo
Copy link
Collaborator

Description

Fixes https://github.com/ROCm/frameworks-internal/issues/15641

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Force using V2 hipify
  • Used similar parameters in all places calling hipify

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant